Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Submit feedback
Sign in
Toggle navigation
cate
Project overview
Project overview
Details
Activity
Releases
Cycle Analytics
Insights
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Locked Files
Issues
4
Issues
4
List
Boards
Labels
Service Desk
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Security & Compliance
Security & Compliance
Dependency List
Packages
Packages
Container Registry
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
PCOG
cate
Commits
2e7a3214
Verified
Commit
2e7a3214
authored
Mar 15, 2019
by
Raphaël Bleuse
1
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix SVG export of torsions
parent
26b9a1c7
Pipeline
#10206
passed with stage
in 24 seconds
Changes
2
Pipelines
1
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
19 additions
and
14 deletions
+19
-14
Changelog.rst
Changelog.rst
+17
-12
src/cate/_svg.py
src/cate/_svg.py
+2
-2
No files found.
Changelog.rst
View file @
2e7a3214
...
...
@@ -14,6 +14,11 @@ This projects adheres to `Semantic Versioning <https://semver.org/spec/v2.0.0.ht
Unreleased_
===========
Fixed
-----
- [bug] The depiction of torsions now respects the sign convention.
1.0b0_ -- 2019-01-04
====================
...
...
@@ -21,11 +26,11 @@ Unreleased_
Added
-----
- [code] `
core.Template
` class is now the interface to manipulate templates.
- [code] `
core.convert_order_position
` to convert an order vector into a
- [code] `
`core.Template`
` class is now the interface to manipulate templates.
- [code] `
`core.convert_order_position`
` to convert an order vector into a
position vector, and vice-versa.
- [code] `
export
` module to manage supported export formats.
- [code] New external dependency `
multiset
`.
- [code] `
`export`
` module to manage supported export formats.
- [code] New external dependency `
`multiset`
`.
Changed
-------
...
...
@@ -33,7 +38,7 @@ Changed
- [code] Complete rewrite of the optimization logic to compute of a
depth-optimal sequence of crossings.
- [code] Complete refactor of the SVG export code.
- [code] Public namespaces of each module have been cleaned of all unecessary
- [code] Public namespaces of each module have been cleaned of all un
n
ecessary
objects.
- [doc] Improve README.
...
...
@@ -41,13 +46,13 @@ Changed
Removed
-------
- [code] Legacy optimization logic of `
main
` module:
- `
all_subsets`, `createTree`, `detectDoubles`, `getNeighbours
`,
`
getPermutations`, `getTorsions`, `updatePermutationList
` and
`
updatePosition
` functions.
- `
Node` and `Tree
` classes.
- [code] Legacy drawing logic: `
drawTemplate` module and `main.drawSVGTemplate`
function.
- [code] Legacy optimization logic of `
`main`
` module:
- `
`all_subsets``, ``createTree``, ``detectDoubles``, ``getNeighbours`
`,
`
`getPermutations``, ``getTorsions``, ``updatePermutationList`
` and
`
`updatePosition`
` functions.
- `
`Node`` and ``Tree`
` classes.
- [code] Legacy drawing logic: `
`drawTemplate`` module and
``main.drawSVGTemplate``
function.
Fixed
-----
...
...
src/cate/_svg.py
View file @
2e7a3214
...
...
@@ -97,7 +97,7 @@ class _SVGDrawer:
self
.
dwg
.
defs
.
add
(
sprite
)
return
sprite
def
_create_
pos
_torsion_sprite
(
self
):
def
_create_
neg
_torsion_sprite
(
self
):
mask
=
self
.
dwg
.
mask
()
# emulate the overlap of the boundaries with a mask
sprite
=
self
.
dwg
.
g
(
class_
=
'strand'
)
mask
.
add
(
...
...
@@ -137,7 +137,7 @@ class _SVGDrawer:
self
.
dwg
.
defs
.
add
(
sprite
)
return
sprite
def
_create_
neg
_torsion_sprite
(
self
):
def
_create_
pos
_torsion_sprite
(
self
):
mask
=
self
.
dwg
.
mask
()
# emulate the overlap of the boundaries with a mask
sprite
=
self
.
dwg
.
g
(
class_
=
'strand'
)
mask
.
add
(
...
...
Raphaël Bleuse
@rbleuse
mentioned in issue
#15 (closed)
·
Mar 15, 2019
mentioned in issue
#15 (closed)
mentioned in issue #15
Toggle commit list
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment